Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BudgetTerm.f90): ensure that the size of an array is >0 before deallocating #1815

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

fix(BudgetTerm.f90): ensure that the size of an array is >0 before deallocating #1815

wants to merge 9 commits into from

Conversation

emorway-usgs
Copy link
Contributor

  • Fix offered in BudgetTerm was discovered using models that included only a single SFT/SFE reach. Previously, GWF models with a single SFR reach would work. Only transport models would fail.
  • 2 new autotests offered that each use only a single reach
    • The first autotest is for a GWT model (test_gwt_uztmvt2x1). This test ensures that in addition to a single reach, a single MVT connection between UZT and SFT works as expected
    • The 2nd autotest is for a GWE model (test_gwe_drycell_cnd3). This test checks that conduction between SFE and a dry host cell is working as expected in a single-reach model
  • Extended an existing single-reach SFR autotest to include SFT. Prior to this fix, the added GWT model with a single SFT reach would fail because of the bug.
  • Brief description of bug offered in release notes
  • fprettify
  • black

@emorway-usgs emorway-usgs force-pushed the fix_sft branch 3 times, most recently from 7cdf52f to 07f53e6 Compare May 22, 2024 23:17
@emorway-usgs emorway-usgs changed the title fix(BudgetTerm.f90): ensure that the size of an array is >0 before attempting to deallocate fix(BudgetTerm.f90): ensure that the size of an array is >0 before deallocating May 23, 2024
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 6 times, most recently from 238bc44 to 3bfd57e Compare June 21, 2024 23:18
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 5 times, most recently from b42469e to e216987 Compare July 9, 2024 17:36
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 4 times, most recently from 61f642a to 84b1333 Compare July 19, 2024 15:07
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 3 times, most recently from e627f22 to 37a4d61 Compare August 6, 2024 19:22
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 2 times, most recently from 6286915 to 111398d Compare August 14, 2024 16:35
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 3 times, most recently from 6e6f114 to 8c69838 Compare November 8, 2024 17:25
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 2 times, most recently from f83a0e8 to b28c631 Compare November 20, 2024 14:47
@wpbonelli wpbonelli added this to the 6.6.0 milestone Nov 26, 2024
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 2 times, most recently from 3df7bd3 to 1c93510 Compare December 3, 2024 20:29
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 2 times, most recently from 6c53b59 to 9639c7e Compare December 13, 2024 23:48
@wpbonelli wpbonelli modified the milestones: 6.6.0, 6.7.0, 6.6.1 Dec 19, 2024
@emorway-usgs emorway-usgs force-pushed the fix_sft branch 2 times, most recently from 45689bf to f896af9 Compare January 3, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@emorway-usgs @wpbonelli